Homec4science

Fix fatal in Maniphest when viewing "show details" of a task description edit

Authored by epriestley <git@epriestley.com> on Dec 13 2012, 02:15.

Description

Fix fatal in Maniphest when viewing "show details" of a task description edit

Summary:
Clicking "show details" of a task description change in Maniphest currently throws an exception about the markup engine.

Since we don't actually need the engine an alternate fix would be "if ($this->markupEngine) { $renderer->setMarkupEngine($this->markupEngine); }" but we have one at the ready so just provide it. This should become part of the Transactions stuff anyway.

Test Plan: Clicked "show details".

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D4167

Details

Committed
epriestley <git@epriestley.com>Dec 13 2012, 02:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0ba7d34f97f8: Allow phabricator to manage repositories
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH239eca13d753: Fix fatal in Maniphest when viewing "show details" of a task description edit (authored by epriestley <git@epriestley.com>).Dec 13 2012, 02:15