Remove `commit` from DiffusionRequest
23ada21d3552
Actions

Authored by epriestley <git@epriestley.com> on May 13 2014, 22:53.

Description

Remove commit from DiffusionRequest

Summary: Ref T2683. This field is almost entirely redundant with symbolicCommit. Improve how some of the diff query stuff works a bit, then remove it.

Test Plan: Browsed around in all interfaces, looked at a bunch of diffs, etc.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2683

Differential Revision: https://secure.phabricator.com/D9099

Details

Committed

epriestley <git@epriestley.com>

May 13 2014, 22:53

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH347252fda85a: Improve clarity of commit and symbol handling in DiffusionRequest

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH23ada21d3552: Remove `commit` from DiffusionRequest (authored by epriestley <git@epriestley.com>).May 13 2014, 22:53

Changes (9)

				Path
	M			src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php
	M			src/applications/diffusion/controller/DiffusionChangeController.php
	M			src/applications/diffusion/controller/DiffusionDiffController.php
	M			src/applications/diffusion/controller/DiffusionHistoryController.php
	M			src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php
	M			src/applications/diffusion/query/rawdiff/DiffusionMercurialRawDiffQuery.php
	M			src/applications/diffusion/query/rawdiff/DiffusionRawDiffQuery.php
	M			src/applications/diffusion/query/rawdiff/DiffusionSvnRawDiffQuery.php
	M			src/applications/diffusion/request/DiffusionRequest.php