Homec4science

Straighten out absolute/relative URIs in login providers

Authored by epriestley <git@epriestley.com> on Jan 23 2014, 23:03.

Description

Straighten out absolute/relative URIs in login providers

Summary:
Ref T4339. Login providers use absolute URIs, but the ones that rely on local form submits should not, because we want to include CSRF tokens where applicable.

Instead, make the default be relative URIs and turn them into absolute ones for the callback proivders.

Test Plan: Clicked, like, every login button.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4339

Differential Revision: https://secure.phabricator.com/D8045

Details

Committed
epriestley <git@epriestley.com>Jan 23 2014, 23:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa2515921b635: Detect developer error when constructing forms with absolute URIs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH24544b1a2f24: Straighten out absolute/relative URIs in login providers (authored by epriestley <git@epriestley.com>).Jan 23 2014, 23:03