Simplify the implementation of `PhabricatorPHIDType` subclasses
254542237a66
Actions

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 21 2014, 16:38.

Description

Simplify the implementation of PhabricatorPHIDType subclasses

Summary: Instead of implementing the getTypeConstant method in all subclasses of PhabricatorPHIDType, provide a final implementation in the base class which uses reflection. See D9837 for a similar implementation.

Test Plan: Ran arc unit.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9985

Details

Committed

Joshua Spence <josh@joshuaspence.com>

Jul 21 2014, 16:38

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH37106c1b3178: Don't explicitly name abstract base classes

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH254542237a66: Simplify the implementation of `PhabricatorPHIDType` subclasses (authored by Joshua Spence <josh@joshuaspence.com>).Jul 21 2014, 16:38

Changes (66)

				Path
	M			src/applications/auth/phid/PhabricatorAuthPHIDTypeAuthFactor.php
	M			src/applications/calendar/phid/PhabricatorCalendarPHIDTypeEvent.php
	M			src/applications/config/phid/PhabricatorConfigPHIDTypeConfig.php
	M			src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php
	M			src/applications/countdown/phid/PhabricatorCountdownPHIDTypeCountdown.php
	M			src/applications/dashboard/phid/PhabricatorDashboardPHIDTypeDashboard.php
	M			src/applications/dashboard/phid/PhabricatorDashboardPHIDTypePanel.php
	M			src/applications/differential/phid/DifferentialPHIDTypeDiff.php
	M			src/applications/differential/phid/DifferentialPHIDTypeRevision.php
	M			src/applications/diviner/phid/DivinerPHIDTypeAtom.php
	M			src/applications/diviner/phid/DivinerPHIDTypeBook.php
	M			src/applications/drydock/phid/DrydockPHIDTypeBlueprint.php
	M			src/applications/drydock/phid/DrydockPHIDTypeLease.php
	M			src/applications/drydock/phid/DrydockPHIDTypeResource.php
	M			src/applications/files/phid/PhabricatorFilePHIDTypeFile.php
	M			src/applications/harbormaster/phid/HarbormasterPHIDTypeBuild.php
	M			src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildItem.php
	M			src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildLog.php
	M			src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildPlan.php
	M			src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildStep.php
	M			src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildTarget.php
	M			src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildable.php
	M			src/applications/herald/phid/HeraldPHIDTypeRule.php
	M			src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php
	M			src/applications/macro/phid/PhabricatorMacroPHIDTypeMacro.php
	M			src/applications/mailinglists/phid/PhabricatorMailingListPHIDTypeList.php
	M			src/applications/maniphest/phid/ManiphestPHIDTypeTask.php
	M			src/applications/meta/phid/PhabricatorApplicationPHIDTypeApplication.php
	M			src/applications/nuance/phid/NuancePHIDTypeItem.php
	M			src/applications/nuance/phid/NuancePHIDTypeQueue.php
	M			src/applications/nuance/phid/NuancePHIDTypeRequestor.php
	M			src/applications/nuance/phid/NuancePHIDTypeSource.php
	M			src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClient.php
	M			src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClientAuthorization.php
	M			src/applications/owners/phid/PhabricatorOwnersPHIDTypePackage.php
	M			src/applications/passphrase/phid/PassphrasePHIDTypeCredential.php
	M			src/applications/paste/phid/PhabricatorPastePHIDTypePaste.php
	M			src/applications/people/phid/PhabricatorPeoplePHIDTypeExternal.php
	M			src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php
	M			src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php
	M			src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php
	M			src/applications/phid/type/PhabricatorPHIDType.php
	M			src/applications/phlux/phid/PhluxPHIDTypeVariable.php
	M			src/applications/pholio/phid/PholioPHIDTypeImage.php
	M			src/applications/pholio/phid/PholioPHIDTypeMock.php
	M			src/applications/phragment/phid/PhragmentPHIDTypeFragment.php
	M			src/applications/phragment/phid/PhragmentPHIDTypeFragmentVersion.php
	M			src/applications/phragment/phid/PhragmentPHIDTypeSnapshot.php
	M			src/applications/phriction/phid/PhrictionPHIDTypeDocument.php
	M			src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php
	M			src/applications/ponder/phid/PonderPHIDTypeAnswer.php
	M			src/applications/ponder/phid/PonderPHIDTypeQuestion.php
	M			src/applications/project/phid/PhabricatorProjectPHIDTypeColumn.php
	M			src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php
	M			src/applications/releeph/phid/ReleephPHIDTypeBranch.php
	M			src/applications/releeph/phid/ReleephPHIDTypeProduct.php
	M			src/applications/releeph/phid/ReleephPHIDTypeRequest.php
	M			src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php
	M			src/applications/repository/phid/PhabricatorRepositoryPHIDTypeCommit.php
	M			src/applications/repository/phid/PhabricatorRepositoryPHIDTypeMirror.php
	M			src/applications/repository/phid/PhabricatorRepositoryPHIDTypePushEvent.php
	M			src/applications/repository/phid/PhabricatorRepositoryPHIDTypePushLog.php
	M			src/applications/repository/phid/PhabricatorRepositoryPHIDTypeRepository.php
	M			src/applications/slowvote/phid/PhabricatorSlowvotePHIDTypePoll.php
	M			src/applications/tokens/phid/PhabricatorTokenPHIDTypeToken.php
	M			src/applications/transactions/phid/PhabricatorApplicationTransactionPHIDTypeTransaction.php