Homec4science

Fix minor issues with D2630

Authored by epriestley <git@epriestley.com> on Jun 6 2012, 17:15.

Description

Fix minor issues with D2630

Summary:

  • The config is called "resource-path" and the script references "resource-path", but the actual value checked for is "resource-map".
  • Use nonempty(), since defaulting with getEnvConfig() will give you null if the setting exists but is set to null. This default is nearly useless so maybe we should change it to use coalesce().
  • Remove Celerity map initialization from warmup. We don't currently initialize the environment in warmup, and Celerity initialization now depends on the environment.

Test Plan: Ran patch locally and on FPM-Warmup.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: hsb, aran

Differential Revision: https://secure.phabricator.com/D2662

Details

Committed
epriestley <git@epriestley.com>Jun 6 2012, 18:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3e87112d692b: Minor, fix a path issue from the Great File Move. See comment about why this is…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH259638e900de: Fix minor issues with D2630 (authored by epriestley <git@epriestley.com>).Jun 6 2012, 18:12