Homec4science

Respect "End Date" for recurring Calendar events in detail UI

Authored by epriestley <git@epriestley.com> on Sep 8 2016, 18:12.

Description

Respect "End Date" for recurring Calendar events in detail UI

Summary:
Fixes T11396. Currently, you can keep clicking "Next >" forever to generate infinite instances of an event, even if it has a set end date.

Likewise, you can visit /E123/999999 or whatever to stub out the 999999th instance of an event.

Instead:

  • Before creating a new stub, make sure it happens before any end date.
  • 404 stubs if we can't create them.
  • Disable the "Next >" button if it isn't valid.

Test Plan:

  • Visited /E123/9999 for an event with a recurrence end date, got 404.
  • Clicked "Next >" on an event with an end date, got new events until I hit the end date.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11396

Differential Revision: https://secure.phabricator.com/D16517

Details

Committed
epriestley <git@epriestley.com>Sep 8 2016, 19:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5a33a6743e92: Always show a menu on durable column
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH25bd14a9b1e4: Respect "End Date" for recurring Calendar events in detail UI (authored by epriestley <git@epriestley.com>).Sep 8 2016, 19:20