Homec4science

(stable) Stop doing an excessive amount of work in `diffusion.rawdiffquery`

Authored by epriestley <git@epriestley.com> on Sep 20 2016, 14:57.

Description

(stable) Stop doing an excessive amount of work in diffusion.rawdiffquery

Ref T11665.

Without -n 1, this logs the ENTIRE history of the repository. We
actually get the right result, but this is egregiously slow. Add -n 1
to return only one result.

It appears that I wrote this wrong way back in 2011, in D953. This
query is rarely used (until recently) which is likely why it has
escaped notice for so long.

Test Plan: Used Conduit console to execute diffusion.rawdiffquery.
Got the same results but spent 8ms instead of 200ms executing this
command, in a very small repository.

Details

Committed
epriestley <git@epriestley.com>Sep 20 2016, 15:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa768a252af3b: (stable) Add a default value for messageCount so writes from old tiers survive…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH25eea83bc05f: (stable) Stop doing an excessive amount of work in `diffusion.rawdiffquery` (authored by epriestley <git@epriestley.com>).Sep 20 2016, 15:01