Homec4science

Fix an issue with dragging the scrollbar handle from a noninitial position

Authored by epriestley <git@epriestley.com> on Jan 24 2015, 23:00.

Description

Fix an issue with dragging the scrollbar handle from a noninitial position

Summary:
See <rPc40bc0c8bf75#4050>. Repro steps:

  • Scroll partway down the page.
  • Click and drag the scroll handle.

Prior to this diff, the handle incorrectly jumps back to the top of the page. This is because we didn't store the handle's original position. (In testing, I always dragged from near the top of the page, and I don't normally drag scrollbars, so I didn't notice this.)

Test Plan: Clicking and dragging a partially scrolled handle now works correctly.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11483

Details

Committed
epriestley <git@epriestley.com>Jan 24 2015, 23:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPH04ab81aa766c: Use "webkit-overflow-scrolling" on main page scroll view
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH25fc168c95e8: Fix an issue with dragging the scrollbar handle from a noninitial position (authored by epriestley <git@epriestley.com>).Jan 24 2015, 23:00