Homec4science

Plug the establishConnection() Lisk isolation hole

Authored by epriestley <git@epriestley.com> on May 1 2011, 08:06.

Description

Plug the establishConnection() Lisk isolation hole

Summary:
Currently you can still punch through Lisk isolation by calling
establishConnection(), and we do that all over the place. Rename getConnection()
to establishConnection() so that all existing callers are safe, and rename
establishConnection() to establishLiveConnection() so that it's not surprising
when this fails to stub in unit tests.

Not wedded to the name if anyone thinks "establishExternalConnection" or
something is clearer.

Test Plan:
Loaded site, browsed around, ran unit tests.

Reviewed By: aran
Reviewers: aran, tuomaspelkonen, jungejason
CC: aran
Differential Revision: 201

Details

Committed
epriestley <git@epriestley.com>May 1 2011, 17:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPH72e33c9e5a53: Fix a threading issue with Amazon SES
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH260b40b84acd: Plug the establishConnection() Lisk isolation hole (authored by epriestley <git@epriestley.com>).May 1 2011, 17:05