Homec4science

Move sender validation into MailReceiver classes

Authored by epriestley <git@epriestley.com> on May 17 2013, 12:49.

Description

Move sender validation into MailReceiver classes

Summary:
Ref T1205. Finally able to delete a big chunk of this nastiness.

Make MailReceivers responsible for validating senders. For object creation receivers (bugs, conpherences) this just means that users must not be disabled. For other receivers the senders must be able to see the objects, have the right hashes, etc., according to policy.

Test Plan: Added a bunch of test cases (everything except policy). Verified behavior via the Receive test console.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1205

Differential Revision: https://secure.phabricator.com/D5943

Details

Committed
epriestley <git@epriestley.com>May 17 2013, 12:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5243b0d65323: Move computeMailHash() to PhabricatorObjectMailReceiver
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2676e91dd8e1: Move sender validation into MailReceiver classes (authored by epriestley <git@epriestley.com>).May 17 2013, 12:49