Homec4science

Allow users to re-accept or re-reject a revision if they have authority over…

Authored by epriestley <git@epriestley.com> on Jan 18 2017, 21:56.

Description

Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state

Summary:
To set this up:

  • alice accepts a revision.
  • Something adds a package or project she has authority over as a reviewer.
  • Because alice has already accepted, she can not re-accept, but she should be able to (in order to accept on behalf of the new project or package).

Test Plan:

  • Created a revision.
  • Accepted as user "dog".
  • Added "dog project".
  • Re-accepted.
  • Could not three-accept.
  • Removed "dog project.
  • Rejected.
  • Added "dog project".
  • Re-rejected.
  • Could not three-reject.

Reviewers: chad, eadler

Reviewed By: chad, eadler

Differential Revision: https://secure.phabricator.com/D17226

Details

Committed
epriestley <git@epriestley.com>Jan 18 2017, 22:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb8e04fe0419d: Improve handle batching behavior for commit list view
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH269dd81f9178: Allow users to re-accept or re-reject a revision if they have authority over… (authored by epriestley <git@epriestley.com>).Jan 18 2017, 22:16