Homec4science

Remove a bunch of reundant checks for transactions with no effect from Maniphest

Authored by epriestley <git@epriestley.com> on Sep 25 2013, 20:18.

Description

Remove a bunch of reundant checks for transactions with no effect from Maniphest

Summary: Ref T2217. These checks are no longer necessary, ApplicationTransactions handle them for us.

Test Plan:

  • Made a no-effect edit, verified no new transactions showed up.
  • Made real edits, saw them happen and leave transactions.
  • Made an edit which just reorders CCs, saw it detected as no-effect.
  • As above, with projects.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7117

Details

Committed
epriestley <git@epriestley.com>Sep 25 2013, 20:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbef6d82cce11: Allow standard date fields to read default dates as strings
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH26a226b51a65: Remove a bunch of reundant checks for transactions with no effect from Maniphest (authored by epriestley <git@epriestley.com>).Sep 25 2013, 20:18