Homec4science

Allow ApplicationTransaction comments to be edited and deleted

Authored by epriestley <git@epriestley.com> on Dec 11 2012, 23:01.

Description

Allow ApplicationTransaction comments to be edited and deleted

Summary:
Allows you to edit or delete comments in appplications which support ApplicationTransactions.

UI/UX stuff:

  • The dialogs are rough but I want to do a dialog design pass more generally, @chad has some mocks.
  • When you add new mentions via edit, they don't currently count as mentions. I'm not sure what I want to do about this.
  • When you edit or delete a comment, we do not publish any notifications about it. I think this is reasonable.
  • I didn't separate "delete" out versus "edit"; I assume it will be reasonably intuitive that deleting all the text deletes effectively deletes the comment. I also want to discourage deletion somewhat (we still show the transaction, just show that the comment has been deleted).

Test Plan:
Transaction view, note "Edit" and "Edited" links:

{F26914}

Edit view, has some design issues but I want to do a pass on dialogs in general:

{F26915}

History view:

{F26913}

Reviewers: vrana, btrahan, chad

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1082

Differential Revision: https://secure.phabricator.com/D4149

Details

Committed
epriestley <git@epriestley.com>Dec 11 2012, 23:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH93938765c371: Lay in more styles from "diff_full_view.png"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH26dd2a0eef13: Allow ApplicationTransaction comments to be edited and deleted (authored by epriestley <git@epriestley.com>).Dec 11 2012, 23:01