Homec4science

Refactor setting e-mail subjects

Authored by vrana <jakubv@fb.com> on Jun 11 2012, 21:21.

Description

Refactor setting e-mail subjects

Summary:
It seems that Outlook and Mail.app mostly ignores the threading headers and thread primarily by subject.
They are also very picky about the Re: part in the header.
I guess that's because users of these clients often hit Reply when they want to create a new message to the sender of an e-mail.

We need both of these applications to work with the same setting because we don't use multiplexing to prevent sending multiple e-mails to people in lists.
I also believe that the default behavior should just work in most setups.

I've tried several different combinations of putting "Re:" and none of them seems to always work in both clients.

This diff at least adds more abstraction to the code which should prevent copy/paste errors (two fixed by this diff!).

Test Plan: Sent several e-mails with varying subject, verified that they look as before in Outlook and Mail.app.

Reviewers: epriestley, nh

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2709

Details

Committed
vrana <jakubv@fb.com>Jun 12 2012, 04:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe1f2f7f2d9b6: Minor, update celerity map.
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH2793828795d7: Refactor setting e-mail subjects (authored by vrana <jakubv@fb.com>).Jun 12 2012, 04:07