Homec4science

Don't use handles in the Calendar event name migration

Authored by epriestley <git@epriestley.com> on May 15 2015, 20:55.

Description

Don't use handles in the Calendar event name migration

Summary:
Fixes T8209. Using handles can now cause cache fills as a side effect of T7707. Use a raw query instead.

I'll follow up on T8209 with some context and ideas for longer-term fixes.

Test Plan:

  • Set event names to ''.
  • Reran migration with --apply ... --trace.
  • Saw migration work correctly without executing cache fills.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8209

Differential Revision: https://secure.phabricator.com/D12858

Details

Committed
epriestley <git@epriestley.com>May 15 2015, 20:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7179def064a3: Clean up a missed access to Calendar status
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH27b78d214790: Don't use handles in the Calendar event name migration (authored by epriestley <git@epriestley.com>).May 15 2015, 20:55