Homec4science

Transactions - kill the old "show all" code pathways

Authored by Bob Trahan <btrahan@phacility.com> on Dec 4 2014, 23:55.

Description

Transactions - kill the old "show all" code pathways

Summary: we still need to be pager-sensitive, but otherwise this "show all" stuff is dead, dead dead...! Ref T4712. I think we can close the book on T4712 with one more diff to clean up the array_reverse / reverse paging stuff? That diff is probably a bit tricky as it involes auditing every TransactionQuery callsite...

Test Plan: viewed a task with a lot of transactions. clicked "show older" and it worked!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4712

Differential Revision: https://secure.phabricator.com/D10926

Details

Committed
Bob Trahan <btrahan@phacility.com>Dec 4 2014, 23:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6ab3f06b6ec6: Transactions - adding willRenderTimeline to handle tricky cases
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH2856c6093240: Transactions - kill the old "show all" code pathways (authored by Bob Trahan <btrahan@phacility.com>).Dec 4 2014, 23:55