Homec4science

Remove all setObjectURI() from ActionListViews

Authored by epriestley <git@epriestley.com> on Dec 17 2015, 15:31.

Description

Remove all setObjectURI() from ActionListViews

Summary:
Ref T10004. After D14804, we get this behavior by default and no longer need to set it explicitly.

(If some endpoint did eventually need to set it explicitly, it could just change what it passes to setHref(), but I believe we currently have no such endpoints and do not foresee ever having any.)

Test Plan:

  • As a logged out user, clicked various links in Differential, Maniphest, Files, etc., always got redirected to a sensible place after login.
  • Grepped for setObjectURI(), getObjectURI() (there are a few remaining callsites, but to a different method with the same name in Doorkeeper).

Reviewers: chad

Reviewed By: chad

Subscribers: hach-que

Maniphest Tasks: T10004

Differential Revision: https://secure.phabricator.com/D14805

Details

Committed
epriestley <git@epriestley.com>Dec 17 2015, 17:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe869e7df0b79: When logged-out users hit a "Login Required" dialog, try to choose a better…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2868a69f658c: Remove all setObjectURI() from ActionListViews (authored by epriestley <git@epriestley.com>).Dec 17 2015, 17:30