Homec4science

Provide better UX when trying to view binary file from differential

Authored by Nick Harper <nharper@fb.com> on Feb 1 2012, 01:32.

Description

Provide better UX when trying to view binary file from differential

Summary:
When a user selects "show raw file (right)" from the dropdown of a binary file
in differential, they should get more than a blank page.

Test Plan: Loaded a raw binary file from differential

Reviewers: tuomaspelkonen, epriestley, jungejason

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1533

Details

Committed
Nick Harper <nharper@fb.com>Feb 1 2012, 02:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8b4c057c752b: Disable personal Herald rules from invalid owners
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH28c9607fd06e: Provide better UX when trying to view binary file from differential (authored by Nick Harper <nharper@fb.com>).Feb 1 2012, 02:24