Homec4science

Fix some more setIcon() issues

Authored by epriestley <git@epriestley.com> on Aug 31 2016, 18:47.

Description

Fix some more setIcon() issues

Summary: Fixes T11569. This fixes a known bad setIcon(). I also looked for more calls to setIcon() without success, and stubbed setIcon() so we're in good shape even if more exist.

Test Plan:

  • Grepped for setIcon( and manually inspect all 1,004 callsites to look for calls on PHUIObjectItemView objects.
  • Grepped for "high risk" callsites (setIcon in file after PHUIObjectItemView) and re-examined them. I identified these files with this command:
git ls-tree -r --name-only HEAD | xargs pcregrep -i -M -H -c --files-with-matches -o 'PHUIObjectItemView(.|\n)*setIcon'

There might be some more clever way to do that.

  • Since this only identified the callsites I already knew about and I don't have a ton of confidence that I didn't miss any, I put a stub in place that logs a deprecation warning. I'll file a followup to go clean these up in a month or so if the logs are clean.
  • Loaded Nuance, saw it work but warn.
  • Changed Nuance to use setStatusIcon(), loaded Nuance, no more fatal.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11569

Differential Revision: https://secure.phabricator.com/D16477

Details

Committed
epriestley <git@epriestley.com>Aug 31 2016, 19:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPH991e49b7114e: Correct spelling of "therefore"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH29957d196bb1: Fix some more setIcon() issues (authored by epriestley <git@epriestley.com>).Aug 31 2016, 19:00