Homec4science

Don't treat Quicksand requests as isWorkflow() or isAjax()

Authored by epriestley <git@epriestley.com> on Mar 28 2015, 23:45.

Description

Don't treat Quicksand requests as isWorkflow() or isAjax()

Summary:
Fixes T7061. Although it's very simple, I think this is a complete fix.

Quicksand technically is Ajax and uses Workflow as a transport mechanism, but the server should always pretend the user clicked a normal link when rendering.

Test Plan: Links that were autoconverting into dialogs (like "Edit Task") or otherwise making the wrong behavioral choices now work as expected.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7061

Differential Revision: https://secure.phabricator.com/D12194

Details

Committed
epriestley <git@epriestley.com>Mar 28 2015, 23:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH43be66d8b9e7: Fix 'Not Done' button hover state on inline comments
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH29beb174d3b1: Don't treat Quicksand requests as isWorkflow() or isAjax() (authored by epriestley <git@epriestley.com>).Mar 28 2015, 23:45