Homec4science

Improve inline comment previews

Authored by epriestley <git@epriestley.com> on Mar 28 2012, 19:11.

Description

Improve inline comment previews

Summary:

  • When an inline comment preview corresponds to an inline comment on the page, link to it. Just punt in the tough case where the inline is on some other page.
  • In "haunted" mode, "z" now toggles through three modes: normal, comment area only, and comment + previews.

Test Plan:

  • Viewed visible and not-visible inline comment previews, clicked "View" links.
  • Tapped "z" a bunch to toggle haunt modes.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T517, T214

Differential Revision: https://secure.phabricator.com/D2041

Details

Committed
epriestley <git@epriestley.com>Mar 28 2012, 19:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH99b03ffd476f: Prefer PNG for thumbnails of PNG
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH29d8fc04e50b: Improve inline comment previews (authored by epriestley <git@epriestley.com>).Mar 28 2012, 19:11