Homec4science

Have "limit=1" tokenizers replace tokens instead of disabling "Browse"

Authored by epriestley <git@epriestley.com> on Dec 14 2015, 23:51.

Description

Have "limit=1" tokenizers replace tokens instead of disabling "Browse"

Summary:
Fixes T9984. When a tokenizer only allows one selection (like "Task Owner:" or "Land Onto Branch:"), keep the browse button active but have it replace values.

Also, have "Create Subtask" default to the system default status, so subtasks of closed tasks are not also closed.

Test Plan:

  • Browsed an empty limit=1 tokenizer.
  • Replaced a full limit=1 tokenizer.
  • Browsed an empty no-limit tokenizer.
  • Browsed more tokens into the no-limit tokenizer.
  • Typed some tokens normally.
  • Created a subtask of a closed task.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9984

Differential Revision: https://secure.phabricator.com/D14785

Details

Committed
epriestley <git@epriestley.com>Dec 15 2015, 00:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc19654db161b: Write some basic "dealing with Conduit changes" documentation
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH29e2acd5257b: Have "limit=1" tokenizers replace tokens instead of disabling "Browse" (authored by epriestley <git@epriestley.com>).Dec 15 2015, 00:29