Homec4science

Allow columns to be marked as nonmutable (so save() will not change them)

Authored by epriestley <git@epriestley.com> on Feb 19 2015, 19:37.

Description

Allow columns to be marked as nonmutable (so save() will not change them)

Summary:
Ref T6840. This feels a little dirty; open to alternate suggestions.

We currently have a race condition where multiple daemons may load a commit and then save it at the same time, when processing "reverts X" text. Prior to this feature, two daemons would never load a commit at the same time.

The "reverts X" load/save has no effect (doesn't change any object properties), but it will set the state back to the loaded state on save(). This overwrites any flag updates made to the commit in the meantime, and can produce the race in T6840.

In other cases (triggers, harbormaster, repositories) we deal with this kind of problem with "append-only-updates + single-consumer", or a bunch of locking. There isn't really a good place to add a single consumer for commits, since a lot of daemons need to access them. We could move the flags column to a separate table, but this feels pretty complicated. And locking is messy, also mostly because we have so many consumers.

Just exempting this column (which has unusual behavior) from save() feels OK-ish? I don't know if we'll have other use cases for this, and I like it even less if we never do, but this patch is pretty small and feels fairly understandable (that said, I also don't like that it can make some properties just silently not update if you aren't on the lookout).

So, this is a fix, and feels simplest/least-bad for the moment to me, I thiiink.

Test Plan: Added and executed unit tests.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6840

Differential Revision: https://secure.phabricator.com/D11822

Details

Committed
epriestley <git@epriestley.com>Feb 19 2015, 19:37
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6a60b8cb6f2b: Set "importStatus" as nonmutable on save()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH29fd3f136b88: Allow columns to be marked as nonmutable (so save() will not change them) (authored by epriestley <git@epriestley.com>).Feb 19 2015, 19:37