Homec4science

Add email invites to Phabricator (logic only)

Authored by epriestley <git@epriestley.com> on Feb 10 2015, 01:12.

Description

Add email invites to Phabricator (logic only)

Summary:
Ref T7152. This builds the core of email invites and implements all the hard logic for them, covering it with a pile of tests.

There's no UI to create these yet, so users can't actually get invites (and administrators can't send them).

This stuff is a complicated mess because there are so many interactions between accounts, email addresses, email verification, email primary-ness, and user verification. However, I think I got it right and got test coverage everwhere.

The degree to which this is exception-driven is a little icky, but I think it's a reasonable way to get the testability we want while still making it hard for callers to get the flow wrong. In particular, I expect there to be at least two callers (one invite flow in the upstream, and one derived invite flow in Instances) so I believe there is merit in burying as much of this logic inside the Engine as is reasonably possible.

Test Plan: Unit tests only.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7152

Differential Revision: https://secure.phabricator.com/D11723

Details

Committed
epriestley <git@epriestley.com>Feb 10 2015, 01:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHac504f232fed: Projects - smooth out scenarios around renaming a project and slugs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2a0af8e2995d: Add email invites to Phabricator (logic only) (authored by epriestley <git@epriestley.com>).Feb 10 2015, 01:12