Homec4science

Bring Javelin into Phabricator via git submodule, not copy-and-paste

Authored by epriestley <git@epriestley.com> on May 4 2011, 00:11.

Description

Bring Javelin into Phabricator via git submodule, not copy-and-paste

Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.

Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.

Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test

Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows

Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223

Details

Committed
epriestley <git@epriestley.com>May 8 2011, 22:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH846d625ed0eb: [differential] gmail-compatible emails
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2a39fd09ebe7: Bring Javelin into Phabricator via git submodule, not copy-and-paste (authored by epriestley <git@epriestley.com>).May 8 2011, 22:20