Homec4science

Fix several issues with Differential exception email

Authored by epriestley <git@epriestley.com> on Jul 12 2012, 22:33.

Description

Fix several issues with Differential exception email

Summary:

  • Assigning $cc_phids clobbers the correct value assigned on line 80.
  • Remove stack trace noise, the trace is always meaningless and well-known.
  • Actually show the original body.

Test Plan: Piped mail to the mail receiver and verified the errors didn't CC revision CCs, no longer had traces, and included the original raw text body.

Reviewers: btrahan, jungejason

Reviewed By: jungejason

CC: aran

Differential Revision: https://secure.phabricator.com/D2969

Details

Committed
epriestley <git@epriestley.com>Jul 12 2012, 22:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH241c81091640: Merge pull request #152 from flxf/readme_220
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2b690372dedc: Fix several issues with Differential exception email (authored by epriestley <git@epriestley.com>).Jul 12 2012, 22:33