Homec4science

Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"

Authored by epriestley <git@epriestley.com> on Jun 22 2016, 19:24.

Description

Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"

Summary:
Ref T11179. This splits "Edit Blocking Tasks" into two options now that we have more room ("Edit Parent Tasks", "Edit Subtasks").

This also renames "Blocking" tasks to "Subtasks", and "Blocked" tasks to "Parent" tasks. My goals here are:

  • Make the relationship direction more clear: it's more clear which way is up with "parent" and "subtask" at a glance than with "blocking" and "blocked" or "dependent" and "dependency".
  • Align language with "Create Subtask".
  • To some small degree, use more flexible/general-purpose language, although I haven't seen any real confusion here.

Fixes T6815. I think I narrowed this down to two issues:

  • Just throwing a bare exeception (we now return a dialog explicitly).
  • Not killing open transactions when the cyclec check fails (we now kill them).

Test Plan:

  • Edited parent tasks.
  • Edited subtasks.
  • Tried to introduce graph cycles, got a nice error dialog.

{F1697087}

{F1697088}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6815, T11179

Differential Revision: https://secure.phabricator.com/D16166

Details

Committed
epriestley <git@epriestley.com>Jun 22 2016, 20:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdbf13f79e99e: Allow the object selector dialog to be resized
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2cb779575dd5: Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks" (authored by epriestley <git@epriestley.com>).Jun 22 2016, 20:20