Homec4science

Fix 20130820.file-mailkey-populate.php for databases in strict mode

Authored by epriestley <git@epriestley.com> on Sep 6 2013, 00:58.

Description

Fix 20130820.file-mailkey-populate.php for databases in strict mode

Summary:
Fixes T3803. Turns out my advice was sort of terrible. :/

In strict mode, the INSERT INTO x (y, z) raises an error unless (y, z, ...) includes all columns without default values.

Test Plan: Ran storage upgrade on a strict-mode install. Verified no inserts were performed.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3803

Differential Revision: https://secure.phabricator.com/D6894

Details

Committed
epriestley <git@epriestley.com>Sep 6 2013, 00:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH228496cdbe16: File - add transactions and editor
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2d240142c89a: Fix 20130820.file-mailkey-populate.php for databases in strict mode (authored by epriestley <git@epriestley.com>).Sep 6 2013, 00:58