Homec4science

Basic filename search support for Diffusion

Authored by Vlad Albulescu <vlada@fb.com> on Feb 1 2014, 17:32.

Description

Basic filename search support for Diffusion

Summary:
Ref T156. Adds basic filename search support for Diffusion,
currently only for Git repositories.

This is preliminary, and it's up for discussion:

  • is the UI in the right place;
  • what should the search query syntax be (e.g. whether to put *s in the beginning and end of it);
  • how to best approach it for Mercurial and/or SVN;
  • what's the cleanest result format for lsquery (I went for the minimum necessary change to DiffusionBrowseSearchController).

Test Plan:
Browse to a repository in Diffusion, and use both
Search File Names and Search File Content.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T156

Differential Revision: https://secure.phabricator.com/D8093

Details

Committed
epriestley <git@epriestley.com>Feb 1 2014, 17:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH99676e8e331b: Add app icons to quick menu
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2d27324bef95: Basic filename search support for Diffusion (authored by Vlad Albulescu <vlada@fb.com>).Feb 1 2014, 17:33