OAuth - add a little notes section for admins to remember details about…
2d43cf12964d
Actions

Authored by Bob Trahan <btrahan@phacility.com> on Apr 9 2014, 20:09.

Description

OAuth - add a little notes section for admins to remember details about external accounts

Summary: Fixes T4755. This also includes putting in a note that Google might ToS you to use the Google+ API. Lots of code here as there was some repeated stuff between OAuth1 and OAuth2 so I made a base OAuth with less-base OAuth1 and OAuth2 inheriting from it. The JIRA provider remains an independent mess and didn't get the notes field thing.

Test Plan: looked at providers and read pretty instructions.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4755

Differential Revision: https://secure.phabricator.com/D8726

Details

Committed

Bob Trahan <btrahan@phacility.com>

Apr 9 2014, 20:09

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH8b3eced0c74d: Make Maniphest project prefill more modern and standard

Branches

Unknown

Tags

Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH2d43cf12964d: OAuth - add a little notes section for admins to remember details about… (authored by Bob Trahan <btrahan@phacility.com>).Apr 9 2014, 20:09

Changes (13)

				Path
	M			src/__phutil_library_map__.php
	V			src/applications/auth/provider/{PhabricatorAuthProviderOAuth.php → PhabricatorAuthProviderOAuth2.php}
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuth1.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuth1JIRA.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuth1Twitter.php
	V			src/applications/auth/provider/{PhabricatorAuthProviderOAuth2.php ← PhabricatorAuthProviderOAuth.php}
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuthAmazon.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuthAsana.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuthDisqus.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuthFacebook.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuthGitHub.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuthGoogle.php
	M			src/applications/auth/provider/PhabricatorAuthProviderOAuthTwitch.php