Homec4science

(stable) Allow menu items to render their own content; make Dashboard items…

Authored by epriestley <git@epriestley.com> on Jan 26 2017, 21:14.

Description

(stable) Allow menu items to render their own content; make Dashboard items render on-page

Summary:
Ref T11957. When you click a dashboard item, it now sends you to /<app>/item/view/123/, which renders the proper crumbs, navigation, etc., with the dashboard as page content.

This works as you'd expect in Projects:

{F2508568}

It's sliiiightly odd in Favorites since we nuke the nav menu, but seems basically fine?

{F2508571}

Test Plan:

  • Created a dashboard panel on a project.
  • Clicked it, saw it render.
  • Made it the default panel, viewed project default screen, saw dashboard.
  • Disabled every panel I could, still saw reasonable behavior (this is silly anyway).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11957

Differential Revision: https://secure.phabricator.com/D17255

Details

Committed
epriestley <git@epriestley.com>Jan 27 2017, 20:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH23c54262caf8: Fix fatal saving menu items without custom validation
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2dc4692021c3: (stable) Allow menu items to render their own content; make Dashboard items… (authored by epriestley <git@epriestley.com>).Jan 27 2017, 20:55