Homec4science

Remove DifferentialChangesetRenderer->(g|s)etLineCount()

Authored by epriestley <git@epriestley.com> on Jan 14 2013, 23:20.

Description

Remove DifferentialChangesetRenderer->(g|s)etLineCount()

Summary: The "line count" is always the same as count($this->getOldLines()), and somewhat misleading since it's really "number of rows in the two-up view". D4421 removed the only (or only remaining?) call.

Test Plan: looked at some diffs

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4422

Details

Committed
epriestley <git@epriestley.com>Jan 14 2013, 23:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH612b29fff40a: Implement basic one-up and test renderers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2de107f21b2c: Remove DifferentialChangesetRenderer->(g|s)etLineCount() (authored by epriestley <git@epriestley.com>).Jan 14 2013, 23:20