Homec4science

Bind file thumbnail visibility to the visibility of the original files

Authored by epriestley <git@epriestley.com> on Sep 4 2014, 21:49.

Description

Bind file thumbnail visibility to the visibility of the original files

Summary:
Ref T6013. Currently, when we create a thumbnail, it gets its own (default) file visibility policy.

In particular, this causes the issue in T6013: thumbnails get "all users" visibility, which does not include logged-out users.

Instead, a thumbnail should just have the same visibility as the original file does. Enforce this:

  • When loading thumbnails, reject thumbnails with invisible originals.
  • When filtering thumbnails, permit thumbnails with visible originals.

Test Plan: As a logged-out user, thumbnails are now visible when the original files are attached to visible objects.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6013

Differential Revision: https://secure.phabricator.com/D10410

Details

Committed
epriestley <git@epriestley.com>Sep 4 2014, 21:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8efea3abe958: Add a configuration warning when `memory_limit` will limit file uploads
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2e0361bd98c4: Bind file thumbnail visibility to the visibility of the original files (authored by epriestley <git@epriestley.com>).Sep 4 2014, 21:49