Homec4science

Fix excessively-conservative feed story policy checks

Authored by epriestley <git@epriestley.com> on May 10 2015, 19:55.

Description

Fix excessively-conservative feed story policy checks

Summary:
When checking if a user can see a feed story about an object, we currently use the object's primary policy but ignore automatic capabilities.

Instead, proxy both primary policies and automatic capabilities.

Test Plan:

  • Before this patch, users could not see stories about events they were invited to but not permitted to see by the primary policy (this is currently the default for newly created events).
  • After this patch, these invited users can now see the stories.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: lpriestley, epriestley

Differential Revision: https://secure.phabricator.com/D12785

Details

Committed
epriestley <git@epriestley.com>May 10 2015, 19:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa03a488ba61b: Don't claim logged out users are automatically subscribed to un-owned objects
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2e54b3ff57a5: Fix excessively-conservative feed story policy checks (authored by epriestley <git@epriestley.com>).May 10 2015, 19:55