Homec4science

Store metadata with Differential and Maniphest comments, and store added…

Authored by epriestley <git@epriestley.com> on Jun 1 2011, 20:19.

Description

Store metadata with Differential and Maniphest comments, and store added reviewers as metadata

Summary:
The "Add reviewer" implementation is super lazy right now since I didn't want to
do a schema change. Man up and add a column. I also plan to store "via"
information here (e.g., via email or via mobile).

NOTE: This schema change may take a while since the comment table is pretty big in Facebook's install.

This needs a little CSS work but I think it's reasonable for now.

Test Plan:
Made comments on revisions and tasks. Added reviewers to a revision, got linked
names instead of a blob of text.

Reviewed By: aran
Reviewers: tomo, jungejason, tuomaspelkonen, aran
Commenters: tomo
CC: aran, tomo, epriestley
Differential Revision: 394

Details

Committed
epriestley <git@epriestley.com>Jun 9 2011, 19:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPH22c1b386558e: herald: add the ability to execute a rule the first time only
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2e8990e9e09b: Store metadata with Differential and Maniphest comments, and store added… (authored by epriestley <git@epriestley.com>).Jun 9 2011, 19:43