Homec4science

Fix an issue where projects queried in "Any Projects" in Maniphest did not have…

Authored by epriestley <git@epriestley.com> on Nov 8 2012, 18:05.

Description

Fix an issue where projects queried in "Any Projects" in Maniphest did not have their handles loaded

Summary:
See https://github.com/facebook/phabricator/issues/230.

If you searched for a project with the "Any Projects" field, we didn't explicitly include it in the list of handles to fetch. Usually this works fine because something else fetches the handle, but if you, e.g., search for a project that has no tasks, you get a fatal.

Test Plan:
Reproduced fatal described in report by performing a custom query for "Any Projects" using a project with no tasks; applied patch; query worked correctly.

Verified $xproject_phids and $project_phids are already queried.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3923

Details

Committed
epriestley <git@epriestley.com>Nov 8 2012, 18:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc812d7d68654: Add a simple button UIExample
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2e993f756118: Fix an issue where projects queried in "Any Projects" in Maniphest did not have… (authored by epriestley <git@epriestley.com>).Nov 8 2012, 18:05