Homec4science

Truncate large strings in DarkConsole

Authored by epriestley <git@epriestley.com> on Jun 18 2015, 22:05.

Description

Truncate large strings in DarkConsole

Summary:
Ref T8597. If a page issues a large query (like inserting a blob into file storage), we may try to utf8ize the entire thing. This is slow and pointless.

Instead, truncate tab data after 4096 bytes before sanitizing.

Test Plan: Adjusted limit to 256 bytes, saw long queries get truncated reasonably.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8597

Differential Revision: https://secure.phabricator.com/D13347

Details

Committed
epriestley <git@epriestley.com>Jun 18 2015, 22:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe291b906419a: Format Calendar list objects
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2eb73619d1c4: Truncate large strings in DarkConsole (authored by epriestley <git@epriestley.com>).Jun 18 2015, 22:05