Homec4science

Fix an open redirect issue in Phame with "View Live"

Authored by epriestley <git@epriestley.com> on Feb 20 2013, 01:04.

Description

Fix an open redirect issue in Phame with "View Live"

Summary: Currently, you can set a blog URI to "evil.com" and then the live controller will issue a redirect. Instead, require a CSRF check. If it fails, pop a "this blog has moved" dialog.

Test Plan:

  • Clicked "View Live" for in-app and on-domain blogs and posts.
  • Hit URI directly.

{F33302}

Reviewers: vrana

Reviewed By: vrana

CC: cbg, aran

Differential Revision: https://secure.phabricator.com/D5021

Details

Committed
epriestley <git@epriestley.com>Feb 20 2013, 01:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPH17cabea1bcba: I am not good at computer
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2f6613846489: Fix an open redirect issue in Phame with "View Live" (authored by epriestley <git@epriestley.com>).Feb 20 2013, 01:04