Homec4science

Markup project hashtags which begin with (or contain only) digits

Authored by epriestley <git@epriestley.com> on Nov 23 2015, 14:51.

Description

Markup project hashtags which begin with (or contain only) digits

Summary:
Fixes T9832. We currently refuse to recognize project hashtags in remarkup if they begin with a digit. This is motivated by attempting to not recognize them if they contain only digits.

I don't think we really gain anything by this. Although most #123 in text are probably not project references, the cost of doing a lookup for them is quite small, and some of them are.

In cases where users use #123 to refer to tasks in an external system, they can use a rule for that with higher precedence than this one or not give their projects conflicting hashtags.

Test Plan:

  • This is well-covered by unit tests.
  • Referenced a #3u1, per T9832.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9832

Differential Revision: https://secure.phabricator.com/D14547

Details

Committed
epriestley <git@epriestley.com>Nov 23 2015, 15:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2a063a93a974: Fix constant in PhameBlogTransaction
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2f7010d18e4f: Markup project hashtags which begin with (or contain only) digits (authored by epriestley <git@epriestley.com>).Nov 23 2015, 15:50