Homec4science

Allow only one global top menu to be open at a time

Authored by epriestley <git@epriestley.com> on Aug 13 2013, 23:57.

Description

Allow only one global top menu to be open at a time

Summary: Fixes T3715. Makes "visible" global instead of per-menu, so all the menus share a visible state.

Test Plan: For menus A and B, clicked "A, A", "A, B, A", "A, B, B", "A, B, B, A", etc. Couldn't figure out a way to break it.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3715

Differential Revision: https://secure.phabricator.com/D6745

Details

Committed
epriestley <git@epriestley.com>Aug 13 2013, 23:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa530004ac7db: Raise an error if a user tries to register with an excessively long username
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3021e1d52dfe: Allow only one global top menu to be open at a time (authored by epriestley <git@epriestley.com>).Aug 13 2013, 23:57