Homec4science

Reduce reliance on `getRevisionID()` on DifferentialComment

Authored by epriestley <git@epriestley.com> on Feb 12 2014, 23:34.

Description

Reduce reliance on getRevisionID() on DifferentialComment

Summary: Ref T2222. A few rendering interfaces rely on fishing the revision ID out of a DifferentialComment, but it will only have the PHID soon. Pass in the revision and use it to determine the ID instead.

Test Plan: Browsed, previewed, examined comments. Clicked anchors.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8209

Details

Committed
epriestley <git@epriestley.com>Feb 12 2014, 23:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPH143b89286aad: Remove unreachable DifferentialRevisionStatsView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3092efdc65a4: Reduce reliance on `getRevisionID()` on DifferentialComment (authored by epriestley <git@epriestley.com>).Feb 12 2014, 23:34