Homec4science

Load and attach objects when loading application transactions

Authored by epriestley <git@epriestley.com> on Feb 19 2014, 01:32.

Description

Load and attach objects when loading application transactions

Summary:
Ref T3886. Fixes the removed TODO. This also implements the generally reasonable policy "you have to be able to see an object in order to see its transactions". That was implicit before (we never load transactions without loading an object first) but is now explicit.

This fixes bad (nonspecialized) rendering of custom field transactions in Projects, and shortly in Differential, where stories would read "alincoln edited this object." instead of a more specific string.

Test Plan: Viewed a project edit, saw a more specific string. Browed ApplicationTransaction applications.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3886

Differential Revision: https://secure.phabricator.com/D8273

Details

Committed
epriestley <git@epriestley.com>Feb 19 2014, 01:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdcd7a316d239: Differential - add DifferentialDraft to track whether revisions have draft…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3103ce33b82d: Load and attach objects when loading application transactions (authored by epriestley <git@epriestley.com>).Feb 19 2014, 01:32