Homec4science

Fix dialog z-index issue

Authored by epriestley <git@epriestley.com> on Jan 29 2015, 16:10.

Description

Fix dialog z-index issue

Summary:
Fixes T7081. History here:

  • JX.Scrollbar made the page scroll weird when a dialog came up because it was half-frame and half-document.
  • I made it fully frame-level.
  • But this wasn't really right; a better fix is to make it fully document-level.

Test Plan:

  • Weird scroll on opening dialog is still fixed.
  • iOS Safari no longer puts the mask over the dialog.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7081

Differential Revision: https://secure.phabricator.com/D11559

Details

Committed
epriestley <git@epriestley.com>Jan 29 2015, 16:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH82f506f175b1: Check to make sure credential is not null in SSH command interface
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH31c64b6772da: Fix dialog z-index issue (authored by epriestley <git@epriestley.com>).Jan 29 2015, 16:10