Homec4science

Add support for postponed linters

Authored by Andrew Gallagher <agallagher@fb.com> on Jun 15 2012, 02:09.

Description

Add support for postponed linters

Summary:
This adds:

  1. A new "arc:lint-postponed" diff property which stores a list of

lint names that are postponed and a finishpostponedlinters conduit
method which removes linters from this list. Postponed linters are
shown in the lint details.

  1. A updatelintmessages conduit message, which adds additional lint

messages to the "arc:lint" diff property.

In combination, this provides very basic support for running
asynchronous static analysis tools. When the diff is being created,
a list of asynchronous static analysis runs can be added to the
diff's postponed linters list. As these postponed linters finish
up, then can report new lint messages back to the diff then mark
themselves as complete.

The client is currently responsible for filtering the lint messages
by things like affected lines and files.

Test Plan:
Used conduit call API to add lint messages and remove postponed
linters from a test diff.

Reviewers: epriestley, vrana, nh, jungejason

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1332

Differential Revision: https://secure.phabricator.com/D2792

Details

Committed
Andrew Gallagher <agallagher@fb.com>Jun 29 2012, 03:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPH47cb5d3cc3eb: Revert "Revert "Mark date and time format translatable""
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Gallagher <agallagher@fb.com> committed rPH3223defe96ca: Add support for postponed linters (authored by Andrew Gallagher <agallagher@fb.com>).Jun 29 2012, 03:09