Homec4science

Move timeline anchor targets up to evade a Chrome 55 behavioral change

Authored by epriestley <git@epriestley.com> on Dec 12 2016, 19:33.

Description

Move timeline anchor targets up to evade a Chrome 55 behavioral change

Summary: Fixes T11997. This lifts the targets out of the containing overflow: hidden; div so Chrome is willing to target them.

Test Plan: In Chrome, visited direct comment links and ended up in the right place. Clicked comment anchors, saw browser jump around again.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11997

Differential Revision: https://secure.phabricator.com/D17033

Details

Committed
epriestley <git@epriestley.com>Dec 12 2016, 19:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8e0d936f72c7: Fix two overzealous renames of getPanelKey()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3277e7873211: Move timeline anchor targets up to evade a Chrome 55 behavioral change (authored by epriestley <git@epriestley.com>).Dec 12 2016, 19:39