Homec4science

Support resuming JS uploads of chunked files

Authored by epriestley <git@epriestley.com> on Mar 14 2015, 16:28.

Description

Support resuming JS uploads of chunked files

Summary: Ref T7149. We can't compute hashes of large files efficiently, but we can resume uploads by the same author, with the same name and file size, which are only partially completed. This seems like a reasonable heuristic that is unlikely to ever misfire, even if it's a little magical.

Test Plan:

  • Forced chunking on.
  • Started uploading a chunked file.
  • Closed the browser window.
  • Dropped it into a new window.
  • Upload resumed (!!!)
  • Did this again.
  • Downloaded the final file, which successfully reconstructed the original file.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: joshuaspence, chad, epriestley

Maniphest Tasks: T7149

Differential Revision: https://secure.phabricator.com/D12070

Details

Committed
epriestley <git@epriestley.com>Mar 14 2015, 16:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHaa909ba07213: Shorten buttons on Leaving High Security Page
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH32d8d675357c: Support resuming JS uploads of chunked files (authored by epriestley <git@epriestley.com>).Mar 14 2015, 16:28