Homec4science

Reduce surface area of DifferentialComment API

Authored by epriestley <git@epriestley.com> on Oct 22 2013, 02:01.

Description

Reduce surface area of DifferentialComment API

Summary:
Ref T2222. Shrink the API to make it easier to move this object's storage to ApplicationTransactions.

Fixes T3415. This moves the "Summary" and "Test Plan" into the property list, and thereby fixes all the attribution problems associated with commandeering, creating a revision from another user's diff, etc.

Test Plan: Browsed several revisions.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3415, T2222

Differential Revision: https://secure.phabricator.com/D7375

Details

Committed
epriestley <git@epriestley.com>Oct 22 2013, 02:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcf1c06e157b6: Add custom field storage to Projects
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH32dd8af9e5d5: Reduce surface area of DifferentialComment API (authored by epriestley <git@epriestley.com>).Oct 22 2013, 02:01