Homec4science

Don't fatal when generating patch emails for diffs with binaries

Authored by epriestley <git@epriestley.com> on Apr 10 2012, 02:35.

Description

Don't fatal when generating patch emails for diffs with binaries

Summary:
When Phabricator is configured to generate patch email, we'll fatal if the patch contains binaries and is generating to Git because ArcanistBundle can't load the binary data. Provide a callback to load the data. See D2174.

(This may cause us to generate absolutely enormous emails, but you get what you asked for...)

Test Plan: Created a diff with an image under "send git patches" email configuration.

Reviewers: Makinde, btrahan, vrana, jungejason

Reviewed By: Makinde

CC: aran

Differential Revision: https://secure.phabricator.com/D2175

Details

Committed
epriestley <git@epriestley.com>Apr 10 2012, 02:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPH974b576df09a: Fix whitespace
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH32f12d1f8fb7: Don't fatal when generating patch emails for diffs with binaries (authored by epriestley <git@epriestley.com>).Apr 10 2012, 02:35