Invert include/exclude logic on DivinerAtomQuery
32f669d56665
Actions

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 4 2015, 23:00.

Description

Invert include/exclude logic on DivinerAtomQuery

Summary: Fixes T8401. Change withIncludeGhosts() to withExcludeGhosts() and withIncludeUndocumentable() to withExcludeDocumentable(). In particular, this allows querying for atoms by PHID to work as expected.

Test Plan: I got confused with double negatives so I might have gotten some of these wrong... I poked around Diviner and re-generated documentation to verify that this is working as expected.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8401

Differential Revision: https://secure.phabricator.com/D13157

Details

Committed

Joshua Spence <josh@joshuaspence.com>

Jun 4 2015, 23:23

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH0fc0af6443f3: Let Maniphest send mail again.

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH32f669d56665: Invert include/exclude logic on DivinerAtomQuery (authored by Joshua Spence <josh@joshuaspence.com>).Jun 4 2015, 23:23

Changes (6)

				Path
	M			src/applications/diviner/controller/DivinerAtomController.php
	M			src/applications/diviner/controller/DivinerBookController.php
	M			src/applications/diviner/controller/DivinerFindController.php
	M			src/applications/diviner/publisher/DivinerLivePublisher.php
	M			src/applications/diviner/query/DivinerAtomQuery.php
	M			src/applications/diviner/storage/DivinerLiveBook.php