Homec4science

Fix an issue with paginating queries which reverse vector ordering components

Authored by epriestley <git@epriestley.com> on Jan 21 2016, 19:35.

Description

Fix an issue with paginating queries which reverse vector ordering components

Summary:
Ref T10188. If you issue certain queries which use reverse ordering (like "All tasks, oldest update to newest update") and then try to page forward, we build the paging clause without reversing the column order correctly.

For example, the ordering of "oldest update to newest update" is "dateModified ASC, id ASC", so the second page should include an "id > X" query. Currently, this builds as "id < X" incorrectly instead.

The cause of this is just a failure to re-reverse a reversing flag when constructing the paging clause.

Test Plan:

  • Queried tasks by update, oldest to newest, with no grouping, etc.
  • Paged to second page.
  • After change, got a valid second page with a good query in the Services tab.
  • Made some other normal queries.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10188

Differential Revision: https://secure.phabricator.com/D15076

Details

Committed
epriestley <git@epriestley.com>Jan 21 2016, 20:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6ebe8db3809f: Add a missing key to HarbormasterBuildArtifact
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH358240b80400: Fix an issue with paginating queries which reverse vector ordering components (authored by epriestley <git@epriestley.com>).Jan 21 2016, 20:11